fix: posting date format error

[Hrishabh17]

No description provided.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
apps
exceptions.py	47	11	77%	27, 33, 39–44, 50, 56–61, 67, 73, 79–80
apps/fyle
actions.py	124	7	94%	214, 263, 319–323
constants.py	1	0	100%
helpers.py	235	14	94%	50–57, 66, 376, 470, 477–480, 483–484
models.py	339	21	94%	321–323, 327–329, 333–335, 339–341, 345–347, 351–353, 414, 543–564, 587, 604
queue.py	50	0	100%
serializers.py	41	0	100%
signals.py	35	6	83%	22, 55–56, 69–71
tasks.py	546	87	84%	132, 143–144, 147–148, 151–152, 174–175, 231–251, 263–268, 311–314, 339–343, 353–361, 400–410, 525–585, 906–910, 1048, 1059–1060, 1085–1086
views.py	172	15	91%	84–91, 145, 245–246, 290–291, 316–320, 413–417
apps/internal
actions.py	39	2	95%	31–32
helpers.py	36	13	64%	18–35
serializers.py	30	0	100%
tasks.py	94	32	66%	36–40, 67–72, 117, 131–182
views.py	83	1	99%	39
apps/internal/services
e2e_setup.py	59	0	100%
fixture_factory.py	59	3	95%	218–220
apps/mappings
constants.py	2	0	100%
exceptions.py	71	6	92%	69–71, 79–81
helpers.py	86	2	98%	93, 163
models.py	50	0	100%
schedules.py	15	0	100%
serializers.py	10	0	100%
signals.py	111	14	87%	90–92, 127, 179–184, 190–194, 200–203, 209–210
tasks.py	179	29	84%	118–119, 142–143, 146, 210–227, 255, 258, 261, 267, 270, 276, 316–318, 329, 407
utils.py	34	0	100%
views.py	46	4	91%	34–35, 114–115
apps/sage_intacct
actions.py	29	4	86%	21–22, 49–50
connector.py	847	19	98%	142, 318, 330, 336, 412, 1489, 1788, 1916–1917, 1984–1985, 2021–2022, 2052–2053, 2120–2121, 2156–2157
dependent_fields.py	293	39	87%	348, 384–387, 416–425, 427–428, 430–432, 434–435, 437–438, 440–441, 491, 511, 551–553, 599–601, 649–655, 659–660
enums.py	25	0	100%
helpers.py	74	3	96%	61, 99, 153
models.py	988	67	93%	78–79, 264–275, 405, 412, 456, 477–494, 567, 579, 629, 635, 670, 720–722, 736–749, 760, 796, 848–849, 949, 990, 1219, 1314–1317, 1361, 1363, 1455, 1559–1602, 1700, 1727, 1838, 2213–2215, 2277
queue.py	171	16	91%	45, 53, 58, 105, 130–133, 173, 187, 205–208, 243, 267–270, 305, 330–333
serializers.py	35	0	100%
tasks.py	1440	144	90%	100, 114, 147, 185–186, 190–193, 195, 198, 248, 283–284, 404–405, 411, 414, 457–458, 499–504, 572, 578, 586, 765–766, 786–789, 860–861, 884, 899, 904, 909, 916, 922, 925–927, 930–933, 936–938, 966, 1019–1020, 1101–1102, 1106, 1127, 1161, 1261–1262, 1338–1339, 1341, 1496–1497, 1586–1587, 1590, 1611, 1626, 1632, 1638, 1645, 1651, 1654–1656, 1659–1662, 1665–1667, 1694, 1839, 1851–1860, 1902, 1905–1910, 1913–1917, 2086–2090, 2189–2190, 2396–2406, 2409, 2418–2423, 2457–2459, 2493–2496, 2564–2568, 2577, 2666–2671, 2684, 2699, 2714
utils.py	910	33	96%	742–746, 891, 1210, 1226–1232, 1241–1242, 1983–1987, 2030–2034, 2077–2081, 2125–2129, 2199–2203, 2224, 2233, 2242, 2251–2252
views.py	145	33	77%	127–129, 134–135, 141–142, 185–188, 258–288, 299–314, 327–331
apps/sage_intacct/errors
errors.py	2	0	100%
helpers.py	47	1	98%	80
apps/sage_intacct/exports
ap_payments.py	13	0	100%
bills.py	28	0	100%
charge_card_transactions.py	22	0	100%
expense_reports.py	28	0	100%
helpers.py	56	2	96%	68, 141
journal_entries.py	75	8	89%	180–183, 319–322
reimbursements.py	13	0	100%
apps/tasks
models.py	70	0	100%
serializers.py	6	0	100%
views.py	37	0	100%
apps/users
helpers.py	12	0	100%
models.py	53	0	100%
views.py	17	0	100%
apps/workspaces
actions.py	46	9	80%	65, 84–85, 103, 122–133, 147
enums.py	92	0	100%
helpers.py	8	0	100%
models.py	176	0	100%
permissions.py	34	9	74%	33, 59–67
serializers.py	43	1	98%	54
signals.py	31	0	100%
system_comments.py	19	0	100%
tasks.py	175	9	95%	53–59, 187–194, 235, 267–268, 379
utils.py	9	0	100%
views.py	329	9	97%	110–112, 139–142, 702–703
apps/workspaces/apis/advanced_settings
serializers.py	80	3	96%	260, 263, 266
triggers.py	10	0	100%
views.py	11	0	100%
apps/workspaces/apis/errors
serializers.py	20	0	100%
views.py	15	0	100%
apps/workspaces/apis/export_settings
helpers.py	73	0	100%
serializers.py	103	3	97%	267, 270, 273
triggers.py	56	2	96%	33–34
views.py	11	0	100%
apps/workspaces/apis/import_settings
serializers.py	141	18	87%	232–238, 243–249, 257–265, 283, 286, 314, 317–318, 326
triggers.py	47	1	98%	31
views.py	33	0	100%
fyle_integrations_imports
dataclasses.py	31	0	100%
models.py	23	0	100%
queues.py	34	5	85%	24, 99, 136, 148–149
signals.py	10	0	100%
tasks.py	127	81	36%	69–111, 120–126, 139–208, 212–227, 252–255, 257, 259, 264
fyle_integrations_imports/modules
base.py	188	10	95%	75, 91–92, 95, 126, 230–231, 237–238, 351
categories.py	177	33	81%	80, 96, 99–100, 103–104, 272–273, 283, 296, 298, 342, 351–355, 364–410
cost_centers.py	96	12	88%	132–133, 152–153, 162, 178, 180, 226, 235–239
expense_custom_fields.py	121	7	94%	83–88, 247, 263, 265, 294
merchants.py	106	25	76%	80–83, 111–129, 155–162, 179–180, 190, 203, 205, 235, 238–242
projects.py	130	47	64%	88–91, 106–182, 202–203, 213, 237, 284, 298–302
tax_groups.py	18	0	100%
webhook_attributes.py	130	6	95%	98, 100–102, 213–214
workers
actions.py	21	0	100%
helpers.py	43	0	100%
worker.py	58	3	95%	79–80, 127
TOTAL	10905	929	91%

Tests	Skipped	Failures	Errors	Time
841	0 💤	0 ❌	0 🔥	1m 12s ⏱️

[github-actions]

---

Diff Coverage
Diff: origin/master..HEAD, staged and unstaged changes

apps/sage_intacct/exports/journal_entries.py (100%)

Total: 1 line
Missing: 0 lines
Coverage: 100%

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the journal entries export module to improve date handling. It introduces formatting of the journal entry date using a format_transaction_date function and applies this formatting to the postingDate field in the journal entry payload. The transaction date is computed earlier within the construct_journal_entry_payload function and reused for the postingDate assignment. Import statements are reorganized to include the new formatting function while maintaining existing helper imports. No changes are made to public API signatures.

Poem

📅 A date takes shape with format's grace,
Posting fields find their rightful place,
Imports align in harmonious code,
Transaction dates on a smoother road,
Five lines added, two fade away,
Journal entries brighter today ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is completely missing. The required template sections (Description and Clickup link) are not filled out.	Add a description explaining what the posting date format issue was and how it was fixed. Include a Clickup link if available.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: fixing a posting date format error in journal entries.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/sage_intacct/exports/journal_entries.py`:
- Line 50: format_transaction_date will raise when passed None because it calls
.strftime; update the call site and/or the formatter to safely handle nullable
JournalEntry.transaction_date: check JournalEntry.transaction_date for None
before calling format_transaction_date (or modify format_transaction_date to
accept Optional[datetime] and return None/empty string when input is None), then
assign transaction_date accordingly so exports do not crash; reference symbols:
JournalEntry.transaction_date, format_transaction_date, and the local variable
transaction_date.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Find the JournalEntry model definition
fd -e py -x rg -l "class JournalEntry" {} \;

Repository: fylein/fyle-intacct-api

Length of output: 96

---

🏁 Script executed:

#!/bin/bash
# Search for transaction_date field definition in models
rg -n "transaction_date" --type py -B5 -A5

Repository: fylein/fyle-intacct-api

Length of output: 50379

---

🏁 Script executed:

#!/bin/bash
# Check the format_transaction_date function in helpers.py
cat -n apps/sage_intacct/exports/helpers.py

Repository: fylein/fyle-intacct-api

Length of output: 7234

---

format_transaction_date will crash if transaction_date is None.

The function has no guard against None input — it will raise AttributeError on None.strftime(...). Since JournalEntry.transaction_date is defined as nullable (DateTimeField(null=True)), this is a runtime crash waiting to happen on any export with a null transaction date.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/sage_intacct/exports/journal_entries.py` at line 50,
format_transaction_date will raise when passed None because it calls .strftime;
update the call site and/or the formatter to safely handle nullable
JournalEntry.transaction_date: check JournalEntry.transaction_date for None
before calling format_transaction_date (or modify format_transaction_date to
accept Optional[datetime] and return None/empty string when input is None), then
assign transaction_date accordingly so exports do not crash; reference symbols:
JournalEntry.transaction_date, format_transaction_date, and the local variable
transaction_date.