Fix/related articles query issue #35
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisholley
commented
Jan 31, 2023
| (acc, tag) => (acc.length + tag.length < 512 ? acc + " " + tag : acc), | ||
| article.title // start the query with the title | ||
| ) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
above here is the fix, the rest of the changes are prettier formatting
Contributor
|
shit, I should have assigned myself on it. I wanted to fix this problem in the branch fix/search using algolia recommend but I'm still waiting on dev access. The problem with the current search implementation is that default algolia do some kind of join on tag (instead of using facets feature, could be another fix) and so most of the time return nothing for recommandations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30
the strategy is to shuffle the tags (so we get different related articles each time) before reducing them into a search query with a max length of 512 characters