Skip to content

Require inner join on offer if sorting by offer #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iworkinprogress wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Require inner join on offer if sorting by offer #12

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93aed36
Require inner join on offer if sorting by offer
iworkinprogress Mar 4, 2022
7d211fa
Merge branch 'master' into fix/objkt-offer-sorting
iworkinprogress Mar 4, 2022
db16fcf
Fix comment spacing
iworkinprogress Mar 4, 2022
37dfff7
Remove weird line break GitHub added
iworkinprogress Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/DataLoaders/GenTokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,14 @@ const batchGenTokObjkt = async (genIds) => {
}
}

// offerPrice and offerCreatedAt sort requires a join to offer table
const sortRequiresOffer = sorts.includes(
(sort) => sort == "offerPrice" || sort == "offerCreatedAt"
);

// if the filters says "OFFER NOT NULL", we can use inner join to filter query
if (filters && filters.offer_ne === null) {
query = query.innerJoinAndSelect("objkt.offer", "offer")
if (sortRequiresOffer || (filters && filters.offer_ne === null)) {
query = query.innerJoinAndSelect("objkt.offer", "offer");
}

// add sorting
Expand Down Expand Up @@ -290,4 +295,4 @@ const batchGenTokObjktFeatures = async (ids) => {

return featuresByIds
}
export const createGenTokObjktFeaturesLoader = () => new DataLoader(batchGenTokObjktFeatures)
export const createGenTokObjktFeaturesLoader = () => new DataLoader(batchGenTokObjktFeatures)