Bug fixes and removal of jQuery #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed requirement for jQuery JSON hasOwnProperty added due to parts not always being returned Corrected ship.js file due to global variables and poor syntax
|
wow, working very well! i added this PR on my branch 💃 |
Author
|
No worries, should revisit this sometime with fresh eyes in case I missed anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed requirement for jQuery
JSON hasOwnProperty added due to parts not always being returned
Corrected ship.js file due to global variables
Cleaned PHP files to be more readable
I did these changes and a few more, will be adding name and link to git hub soon on http://fittings.thera.website just I am currently at work,
Thanks for this though.