Skip to content

Conversation

@dudeperf3ct
Copy link
Member

@dudeperf3ct dudeperf3ct commented Aug 4, 2025

Terraform binary is required for CI to pass.

The above requirement is an anti-pattern and should not be recommended. Ideally, we should mock self.tfs.terraform_client.output method under mocked_resource_template_runner and mocked_resource_template_runner.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Terraform binary is required for CI to pass.
@dudeperf3ct dudeperf3ct marked this pull request as ready for review August 4, 2025 14:51
@dudeperf3ct dudeperf3ct requested review from archena and d-lowl August 4, 2025 14:51
@dudeperf3ct dudeperf3ct merged commit 895ef59 into develop Aug 12, 2025
2 checks passed
@dudeperf3ct dudeperf3ct deleted the fix-failing-ci-test branch August 12, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants