Skip to content

Conversation

@strickvl
Copy link
Contributor

Not sure if it was intentional to set access to the remote state container with container_access_type as container. Seems like private would be a better setting. Terraform remote state contains lots and lots of plain-text secrets and so you don't want to enable any kind of public access.

Not sure about the downstream effects elsewhere inside Matcha from this change, but if I'm not mistaken the current setting might be risky from a security perspective.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant