Skip to content
This repository was archived by the owner on Jan 30, 2023. It is now read-only.

Comments

Changed the way error are handled#57

Open
rudolph9 wants to merge 2 commits intomasterfrom
adjust-error-handling
Open

Changed the way error are handled#57
rudolph9 wants to merge 2 commits intomasterfrom
adjust-error-handling

Conversation

@rudolph9
Copy link
Contributor

@rudolph9 rudolph9 commented Mar 26, 2021

Return the raw error so errors can be handled on a per node basis

related futil-js/contexture-elasticsearch#167

Return the raw error so errors can be handled on a per node basis
@decrapifier
Copy link
Contributor

decrapifier commented Mar 26, 2021

Fails
🚫 This PR has failing tests. Please alleviate the errors and commit them
lastCalendarMonth expected { Object (totalRecords, results) } to deeply equal { Object (results, totalRecords) }
Warnings
⚠️

Branch being merged does not follow Git Flow

⚠️ The README has not been updated. Please update the README.
Messages
📖 You reduced the total lines of code! Awesome! 👍
📖 Could not find any browser results.

Generated by 🚫 dangerJS against 37b972f

@rudolph9
Copy link
Contributor Author

rudolph9 commented Mar 26, 2021

This test was failing before any changes were made, fixing now

  1) Date example type test cases lastCalendarMonth:

      AssertionError: expected { Object (totalRecords, results) } to deeply equal { Object (results, totalRecords) }
      + expected - actual

           {
             "date": "2021-02-26T12:53:49-05:00"
             "key": "lastMonth"
           }
      +    {
      +      "date": "2021-03-23T12:53:49-04:00"
      +      "key": "last3Days"
      +    }
      +    {
      +      "date": "2021-03-20T12:53:49-04:00"
      +      "key": "last6Days"
      +    }
      +    {
      +      "date": "2021-03-06T12:53:49-05:00"
      +      "key": "last20Days"
      +    }
         ]
      -  "totalRecords": 1
      +  "totalRecords": 4
       }
      
      at testRange (test/date.js:133:48)  1) Date example type test cases lastCalendarMonth:

      AssertionError: expected { Object (totalRecords, results) } to deeply equal { Object (results, totalRecords) }
      + expected - actual

           {
             "date": "2021-02-26T12:53:49-05:00"
             "key": "lastMonth"
           }
      +    {
      +      "date": "2021-03-23T12:53:49-04:00"
      +      "key": "last3Days"
      +    }
      +    {
      +      "date": "2021-03-20T12:53:49-04:00"
      +      "key": "last6Days"
      +    }
      +    {
      +      "date": "2021-03-06T12:53:49-05:00"
      +      "key": "last20Days"
      +    }
         ]
      -  "totalRecords": 1
      +  "totalRecords": 4
       }
      
      at testRange (test/date.js:133:48)

related:
https://github.com/smartprocure/contexture/pull/54/files

@rudolph9
Copy link
Contributor Author

rudolph9 commented Mar 29, 2021

the tests are fixed by smartprocure/contexture#58

@rudolph9
Copy link
Contributor Author

closing, this is old and I don't think needed anymore

@rudolph9 rudolph9 closed this Oct 24, 2022
@stellarhoof stellarhoof reopened this Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants