-
Notifications
You must be signed in to change notification settings - Fork 1
enable lineage id feature by default #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable lineage id feature by default #141
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 90.19% 90.20%
=======================================
Files 52 52
Lines 2652 2654 +2
=======================================
+ Hits 2392 2394 +2
Misses 260 260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hmm.. now I am thinking it is actually a bit more complicated. Should we have lineage_attr already on solution tracks (the same way as for track ids)? And should we always recompute the track ids and lineage ids when importing tracks, or do we trust the values we get from external tracks? They may have a different way of calculating the lineage ids, so maybe it is safer to just not import these at all and always recompute? |
|
Notes from discussion:
|
|
Lineage ID is added to Tracks the same way as track ID and tests are updated. I checked that we no longer get a key error in motile tracker when plotting Lineage IDs or adding a lineage to a group. In case we import existing lineage IDs, we check that they are single isolated components (geff check) and that no values are missing. I corrupted the lineage IDs by changing one value to a letter, in that case the user sees an error in the import dialog (invalid literal for int()), so they cannot load it in that corrupt state. And when the lineage IDs are not single isolated connected components, the lineage IDs get relabeled. |
cmalinmayor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Should fix the bug observed in motile-tracker: funkelab/motile_tracker#314, when creating a tracking result with motile.
I will double check tomorrow if this is also true for all imported tracks, especially since force_recompute may be false