-
Notifications
You must be signed in to change notification settings - Fork 1
move motile-toolbox code to funtracks #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move motile-toolbox code to funtracks #140
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 90.20% 90.69% +0.48%
==========================================
Files 52 57 +5
Lines 2654 2847 +193
==========================================
+ Hits 2394 2582 +188
- Misses 260 265 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmalinmayor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐯
cmalinmayor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move over tests for these functions from the toolbox :)
cmalinmayor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Copy motile toolbox code to funtracks. I have done little more than copying the code, ensuring we use the same NodeAttr/EdgeAttr references (though to be deprecated), making sure the tests pass, and making ruff happy. Do we want to do any other reorganization here?