Has keys validator tweaks #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2014 08:35
- We just talked about abstracting the creation of validator functions. Why go back to using the clunky `fn.message` assignment now?
- It seems as though there is a de-facto naming standard in "Functional Javascript" of using nouns for functions which return functions. eg. `checker` returns a function, while `checkCommand` returns an array. If this is correct, it would follow that `hasKeys` would return a boolean, while in fact, if returns a validator function. Renaming the function to `hasKeysValidator` makes it clear that the function returns a validator function.
nuzzesick
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you're accepting pull requests which change example code from the book... just a couple of things I noticed while reading through Ch4, which I think would make the example code easier to grok.
Thank you for the great content in this book! I'm almost to the point where I think functional programming isn't crazy :)