Write send-all! function, keep servers and connections in atoms#2
Open
Juleffel wants to merge 11 commits intoftravers:masterfrom
Open
Write send-all! function, keep servers and connections in atoms#2Juleffel wants to merge 11 commits intoftravers:masterfrom
Juleffel wants to merge 11 commits intoftravers:masterfrom
Conversation
Author
|
On last version of the branch, I added optional input and output functions to start-ws-server in order to preprocess requests coming from client and sent to server. The goal is to interop more easily with reframe-websocket project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this fork was to be able to initiate messages from the server, without loosing the interest of having handlers.
I also wrote some unit tests, modified the doc.
Important change is also that now the servers opened on different ports are all kept under an atom at the library level, with all the client connections done to these servers.