Update targets to .NET 5.0, NET Framework 4.72 and NET Framework 4.8.#33
Draft
Turochamp wants to merge 1 commit intofsprojects:masterfrom
Draft
Update targets to .NET 5.0, NET Framework 4.72 and NET Framework 4.8.#33Turochamp wants to merge 1 commit intofsprojects:masterfrom
Turochamp wants to merge 1 commit intofsprojects:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new version with updated targets, so that package works well with latest versions of .NET SDK.
This PR is a draft with two open questions:
Which targets to include?
Suggest that package includes the versions supported by
dotnet 3.1. Reason is a bug that always restores the latestfsharp.coreversion.More info about
fsharp.corebug:dotnet 3.1 always restores latest fsharp.core version Paket#3769
How to automate testing?
The run all test command in
appveyor-test.ps1(dotnet msbuild /m Tests/tests.proj) does not work anymore, instead I've useddotnet test Foq.sln.