Skip to content

Conversation

@AckerApple
Copy link
Contributor

@AckerApple AckerApple commented Dec 1, 2016

This is very important to me and I have spent a lot if time on this. Please proceed with a more then usual amount of care.

Added

  • options have been added to the method .files
    • options.sync=true allows the entire process to run Synchronously
    • options.shortName=true works just like shortName for other methods
    • options.recursive=false disables recursion like other methods
  • added type 'combine' that works like the argument combine of other methods
  • promiseFiles method that uses native Promises
  • tests to back-up all my work
  • readme.md has been advanced to be far more helpful

@fshost
Copy link
Owner

fshost commented Dec 5, 2016

Working on a releasing a new version with your PR to NPM soon. Thanks.

@AckerApple
Copy link
Contributor Author

What a great way to start the day.

I did notice the Table of Contents, in the README, is not displaying the listed subitems correctly. Most likely due to spacing/tabs being on the wrong stop.

Awesome. Game changing. Thank you extra.

@jharmn
Copy link

jharmn commented Dec 12, 2016

FYI tested with Bluebird, and it works great. Can't wait for NPM release.

@AckerApple
Copy link
Contributor Author

Fantastic, much appreciate the comment. Before this goes live to NPM, the README.md Table of Contents needs to be realigned.

ALSO, I would like to add options{shortName:'relative'} as options{shortName:true} is just the last names of all items which is not terribly helpful.

I actually have time right now, I will get to the above mentioned now.

@AckerApple
Copy link
Contributor Author

AckerApple commented Dec 12, 2016

New pull request has been created with some fantastic material. Lets get this one on NPM!

Pull Request: #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants