Added missing messages #1
Open
+104
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the missing messages from the CPDLC spec (except the deprecated ones), both for FANS and ATN.
I mentioned when there's a different formatted message between FANS and ATN. Maybe we can later split the "Formatted message" into two different columns. Maybe we can also add a column to split the response type between FANS and ATN. That way we can indicate when FANS and ATN have different response type (for example N for FANS, Y for ATN).
I also fixed a few minor mistakes.
For example, "CURRENT ATC UNIT" is not a fixed uplink message. UM183 is a free text message, and "CURRENT ATC UNIT" is one of the messages that can be sent as free text with this uplink message (and it exists only for ATN).
Another change is the replacement of "facility ident", which doesn't exist in the parameters, by "atsu unit". It seems to fit for me in the different cases, but please confirm this is what is expected.