Skip to content

Fix manifest URL generation for PWA apps with query parameter-based language codes #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsbalrog wants to merge 9 commits into
base: frontierMaster
Choose a base branch
from
Open

Fix manifest URL generation for PWA apps with query parameter-based language codes #410

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
086fe4a
fix: update manifest query param issue for PWAs
jsbalrog Jan 29, 2026
9fd0b5e
Update to use URL constructor
jsbalrog Feb 9, 2026
0be4320
Merge branch 'frontierMaster' into fix/manifest-query-param-issue
jsbalrog Feb 9, 2026
688de8c
Merge branch 'fix/manifest-query-param-issue' of https://github.com/f…
jsbalrog Feb 9, 2026
08c20d7
Merge branch 'frontierMaster' into fix/manifest-query-param-issue
jsbalrog Feb 12, 2026
1ae84a8
Restore consideration of appPathOverride
jsbalrog Feb 13, 2026
b80e0ec
Merge branch 'fix/manifest-query-param-issue' of https://github.com/f…
jsbalrog Feb 13, 2026
c9e0be8
Merge branch 'frontierMaster' into fix/manifest-query-param-issue
jsbalrog Feb 18, 2026
b540000
Merge branch 'frontierMaster' into fix/manifest-query-param-issue
jsbalrog Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/react-scripts/layout/views/layout.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@
<link rel="apple-touch-icon" href="<%= typeof logoHref !== 'undefined' ? logoHref : 'https://edge.fscdn.org/assets/components/hf/assets/img/tree-touch-icon-11024a277f1fda5735de5a9f0f4f75ca.png' %>" />

<% if (typeof manifestJsonExists === 'undefined' || manifestJsonExists) { %>
<link rel="manifest" href="<%= typeof appPathOverride !== 'undefined' ? appPathOverride : appPath('') %>/manifest.json" type="application/manifest+json" crossorigin="use-credentials" />
<%
// Construct manifest URL using URL constructor to extract relative path with query params
// Supports both normal app paths and appPathOverride for special routing scenarios
// e.g., http://localhost:5006/africa?lang=en becomes /africa/manifest.json?lang=en
var basePath = typeof appPathOverride !== 'undefined' ? appPathOverride : appPath('');
var url = new URL(basePath);
url.pathname = url.pathname.replace(/\/$/, '') + '/manifest.json';
var manifestUrl = url.pathname + url.search;
%>
<link rel="manifest" href="<%= manifestUrl %>" type="application/manifest+json" crossorigin="use-credentials" />
<% } %>

<!-- Resource Hints -->
Expand Down