Return submit success from Submit. #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful to get a synchronous submit result so that there is context to log/record drops. For example, if an event is being queued, when it is dropped due to queue full, it is not possible to get that event's details in `onDropped` callback. With synchronous result, the dropped event details are available.
boks1971
added a commit
to livekit/protocol
that referenced
this pull request
Feb 12, 2025
NOTE: Need a frostbyte73/core PR to merge and tag a release PR pending: frostbyte73/core#5
frostbyte73
approved these changes
Feb 12, 2025
frostbyte73
approved these changes
Feb 13, 2025
boks1971
added a commit
to livekit/protocol
that referenced
this pull request
Feb 13, 2025
* Webhook analytics event. NOTE: Need a frostbyte73/core PR to merge and tag a release PR pending: frostbyte73/core#5 * sync submit * generated protobuf --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to get a synchronous submit result so that there is context to log/record drops. For example, if an event is being queued, when it is dropped due to queue full, it is not possible to get that event's details in
onDroppedcallback. With synchronous result, the dropped event details are available.