Skip to content

Comments

[DNM] 見出し下の余白を統一#7

Open
takefumi-yoshii wants to merge 2 commits intomainfrom
fix-heading-spacing
Open

[DNM] 見出し下の余白を統一#7
takefumi-yoshii wants to merge 2 commits intomainfrom
fix-heading-spacing

Conversation

@takefumi-yoshii
Copy link
Member

⚠️ caution

これは Webフロントエンドのための実践「テスト」手法 CodeZine Night #1 の発表に向けた仕込み PR です。

@reg-suit
Copy link

reg-suit bot commented Apr 30, 2023

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.


.contentHeader {
margin-bottom: 24px;
margin-bottom: var(--header-bottom-space);
Copy link
Member Author

@takefumi-yoshii takefumi-yoshii Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEMO: このセレクターが使われていなかったため、期待どおりのVRT検出が発動しなかった件が発覚


.contentHeader {
margin-bottom: 24px;
margin-bottom: var(--header-bottom-space);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEMO: 同上

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant