This repository was archived by the owner on Feb 19, 2020. It is now read-only.
Fix support for jabberd2 with GSSAPI #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the reference to kerberos.GSSError.message in any raised exception, because: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6 and its natural repr is probably the most desirable output.
When the GSSAPI mechanism's process() function is invoked for the third time (on success) it must not attempt further processing. Instead it should clean the context and return an empty response.
Despite http://xmpp.org/rfcs/rfc3920.html#rfc.section.6.2, jabberd version 2.2.14 cannot accept the typical "<response xmlns="urn:ietf:params:xml:ns:xmpp-sasl">=</response>". Instead it must be truly empty, so we force an empty response for this stanza only.
Contributor
Author
|
re a918bf3 - see also rtreffer/smack#1 for a similar issue on another client. |
legastero
added a commit
that referenced
this pull request
May 16, 2014
Fix support for jabberd2 with GSSAPI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following minimal changes allow SleekXMPP to connect to a jabberd2 server using Kerberos. Commit a918bf3 breaks an RFC so it's probably more contentious than the other two.