Skip to content

Sanitize fetch error #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MichaelRyanWebber wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

Sanitize fetch error #536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/core/errors/fetch-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ class FetchError extends BaseError {
constructor(options = {}) {
const { resource, init, response, responseBody } = options;
const method = init?.method ?? 'GET';
const initText = init
let initText = init
? init.body instanceof URLSearchParams
? (() => {
init.body = init.body.toString();
return JSON.stringify({ init }, null, 2);
})()
init.body = init.body.toString();
return JSON.stringify({ init }, null, 2);
})()
: JSON.stringify({ init }, null, 2)
: '';
: '';

let responseBodyText = '<response body is unavailable>';
if (typeof responseBody === 'string') {
Expand All @@ -35,10 +35,17 @@ class FetchError extends BaseError {
}
}

const responseHeaderText = response
let responseHeaderText = response
? JSON.stringify({ headers: responseHeaders }, null, 2)
: '';

// sanitize error reporting
if (process.env.STAGE !== 'dev') {
initText = false;
responseHeaderText = false;
responseBodyText = false;
}

const messageParts = [
stripIndent`
-----------------------------------------------------
Expand Down
Loading