fix(devtools): include test/ in npm package files#520
Merged
Conversation
The devtools/index.js exports the test module, but the test/ directory was not included in the package.json files array. This caused builds to fail with: Error: Cannot find module './test' Add test/ to the files array to ensure it's published to npm.
Add documentation about creating pull requests for the Frigg Framework: - Always target the 'next' branch - Always add 'release' and 'prerelease' labels - Ensure project compiles before creating PR
d-klotz
added
release
|
seanspeaks
approved these changes
Dec 15, 2025
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/to thefilesarray in devtoolspackage.jsonProblem
The
devtools/index.jsexports the test module:But the
test/directory was not included in the npm package. This caused builds to fail with:Solution
Add
test/to thefilesarray inpackages/devtools/package.jsonto ensure it's published to npm.Test plan
npm run frigg:local:buildworks after fix@friggframework/devtoolsfrigg buildworks without module not found errors📦 Published PR as canary version:
2.0.0--canary.520.6641121.0✨ Test out this PR locally via:
npm install @friggframework/core@2.0.0--canary.520.6641121.0 npm install @friggframework/devtools@2.0.0--canary.520.6641121.0 npm install @friggframework/eslint-config@2.0.0--canary.520.6641121.0 npm install @friggframework/prettier-config@2.0.0--canary.520.6641121.0 npm install @friggframework/schemas@2.0.0--canary.520.6641121.0 npm install @friggframework/serverless-plugin@2.0.0--canary.520.6641121.0 npm install @friggframework/test@2.0.0--canary.520.6641121.0 npm install @friggframework/ui@2.0.0--canary.520.6641121.0 # or yarn add @friggframework/core@2.0.0--canary.520.6641121.0 yarn add @friggframework/devtools@2.0.0--canary.520.6641121.0 yarn add @friggframework/eslint-config@2.0.0--canary.520.6641121.0 yarn add @friggframework/prettier-config@2.0.0--canary.520.6641121.0 yarn add @friggframework/schemas@2.0.0--canary.520.6641121.0 yarn add @friggframework/serverless-plugin@2.0.0--canary.520.6641121.0 yarn add @friggframework/test@2.0.0--canary.520.6641121.0 yarn add @friggframework/ui@2.0.0--canary.520.6641121.0Version
Published prerelease version:
v2.0.0-next.64Changelog
🐛 Bug Fix
@friggframework/devtools@friggframework/core,@friggframework/devtools,@friggframework/eslint-config,@friggframework/prettier-config,@friggframework/schemas,@friggframework/serverless-plugin,@friggframework/test,@friggframework/uiAuthors: 1