Minimum changes to prevent deprecated messages in PHP 8.1#71
Minimum changes to prevent deprecated messages in PHP 8.1#71mmenavas wants to merge 1 commit intofrictionlessdata:mainfrom
Conversation
|
The tests are failing, but not due to your changes. Give me the weekend and I will modify the Github Actions to fix the issues. |
|
Hi @courtney-miles @mmenavas - hoping to use this library in a project soon and wondering where things stand with PHP 8.1 - happy to help if I can. |
Hi @dafeder! Once this PR is merged, we'll be compatible with PHP 8.1 and 8.2. |
|
@courtney-miles Since the changes on this PR will require dropping support for earlier versions of PHP (PHP <= 8.0), would it be possible to maintain a 1.x version and a 2.x version where the former will continue to support older versions of PHP and the latter 8.1+? |
|
It appears this PR is no longer needed as of 1.2.0 release? |
Overview
This PR adds return types to the methods in
src/Table.phpthat override theIteratorclass. This is necessary because PHP 8.1 requires "overriding methods to declare a compatible return type".Fixes #70.
Please preserve this line to notify @courtney-miles (lead of this repository)