Skip to content

fix: use empty strings instead of : #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaixoo12 wants to merge 1 commit into
base: m83f
Choose a base branch
from
Open

fix: use empty strings instead of : #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ if(WIN32)
if(${SKIA_SYNC_EXTERNAL})
set(SKIA_UPDATE_CMD ${PYTHON_EXECUTABLE} "tools\\git-sync-deps")
else()
set(SKIA_UPDATE_CMD :)
set(SKIA_UPDATE_CMD "")
endif()
set(SKIA_ARGS "target_os=\"windows\" host_os=\"win\" current_os=\"win\" target_cpu=\"x64\" is_component_build=true")
set(SKIA_ARGS "${SKIA_ARGS} clang_win=\"C:\\Program Files\\LLVM\" cc=\"clang-cl\" cxx=\"clang-cl\"")
Expand Down Expand Up @@ -152,11 +152,11 @@ ExternalProject_Add(
gn
SOURCE_DIR ${SKIA_SRC}/gn-src
BINARY_DIR ${SKIA_BUILD_DIR}/gn
DOWNLOAD_COMMAND :
UPDATE_COMMAND :
DOWNLOAD_COMMAND ""
UPDATE_COMMAND ""
CONFIGURE_COMMAND ${PYTHON_EXECUTABLE} ${SKIA_SRC}/gn-src/build/gen.py --out-path ${SKIA_BUILD_DIR}/gn
BUILD_COMMAND ${NINJA_EXECUTABLE} -j${N} -C ${SKIA_BUILD_DIR}/gn
INSTALL_COMMAND :
INSTALL_COMMAND ""
USES_TERMINAL_UPDATE true
USES_TERMINAL_CONFIGURE true
USES_TERMINAL_BUILD true
Expand All @@ -172,12 +172,12 @@ ExternalProject_Add(
skialib
SOURCE_DIR ${SKIA_SRC}
BINARY_DIR ${SKIA_BUILD_DIR}
DOWNLOAD_COMMAND :
DOWNLOAD_COMMAND ""
UPDATE_COMMAND ${SKIA_UPDATE_CMD}
PATCH_COMMAND :
PATCH_COMMAND ""
CONFIGURE_COMMAND ${GN_BIN_PATH} gen --root=${SKIA_SRC} ${SKIA_BUILD_DIR} "--args=${SKIA_ARGS}" ${SKIA_ARGS_EXTRA}
BUILD_COMMAND ${SKIA_BUILD_CMD}
INSTALL_COMMAND :
INSTALL_COMMAND ""
USES_TERMINAL_UPDATE true
USES_TERMINAL_CONFIGURE true
USES_TERMINAL_BUILD true
Expand Down