Skip to content

Conversation

@shsms
Copy link
Collaborator

@shsms shsms commented Jan 7, 2026

No description provided.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Copilot AI review requested due to automatic review settings January 7, 2026 15:12
@shsms shsms requested review from a team as code owners January 7, 2026 15:12
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Jan 7, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the frequenz-microgrid-component-graph dependency from version 0.2.x to 0.3.4 and adjusts test expectations to match the behavioral changes in the new library version.

  • Updated the minimum required version of frequenz-microgrid-component-graph from 0.2.0 to 0.3.4
  • Adjusted test assertion to reflect the new component ordering in formula generation
  • Updated release notes to document the dependency version change

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updated frequenz-microgrid-component-graph dependency version constraint to >= 0.3.4, < 0.4
tests/test_graph_generator.py Updated expected PV formula output to match new component ordering from the updated library
RELEASE_NOTES.md Documented the minimum required version change for frequenz-microgrid-component-graph

The changes are consistent and appropriate for a dependency update that introduces behavioral changes in formula generation. The test updates correctly reflect the new expected behavior, and the release notes properly document this breaking change for users.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graph = await g.get_component_graph(MicrogridId(10))

assert graph.grid_formula() == "COALESCE(#2, #4, 0.0) + #3"
assert graph.pv_formula(None) == "COALESCE(#4, #2, 0.0)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier we preferred inverters as primary, and meters as secondary or fallback. Now the order is reversed.

Because some big sites have one meter and 5 inverters behind them etc, we don't need to process 5 components when we can just do one, during normal operation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a config variable now and can be reversed.

@shsms shsms added this pull request to the merge queue Jan 7, 2026
Merged via the queue into frequenz-floss:v0.x.x with commit 00092ae Jan 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants