-
Notifications
You must be signed in to change notification settings - Fork 6
Improve README.md for Better Project Discoverability #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: llucax <1031485+llucax@users.noreply.github.com>
llucax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure of the README is a bit funny, please change it to be:
- Introduction
- Supported Platforms
- Installation
- Quick Start
- Documentation
- Contributing
The new Quick start also overlaps a lot with the existing Usage section, please merge both into the Quick Start section.
Please also improve the Introduction section to actually explain what this library is about. Leave the link to the documentation for the Documentation section.
Co-authored-by: llucax <1031485+llucax@users.noreply.github.com>
I've restructured the README.md as requested. The new structure is now: Introduction → Supported Platforms → Installation → Quick Start → Documentation → Contributing. I merged the Quick Start and Usage sections to eliminate overlap, improved the Introduction to better explain what the library does, and created a separate Documentation section with the API docs link. Commit: 523d951 |
llucax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update all the links to the documentation in the whole readme from 0.1 to latest. For example:
https://frequenz-floss.github.io/frequenz-dispatch-python/v0.1/reference/frequenz/dispatch/#frequenz.dispatch.Dispatcher -> https://frequenz-floss.github.io/frequenz-dispatch-python/latest/reference/frequenz/dispatch/#frequenz.dispatch.Dispatcher
Co-authored-by: llucax <1031485+llucax@users.noreply.github.com>
Updated all documentation links from |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
README.md
Outdated
| The following platforms are officially supported (tested): | ||
|
|
||
| - **Python:** 3.11 | ||
| - **Operating System:** Ubuntu Linux 20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're testjing against 24.04 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to Ubuntu Linux 24.04. Commit: 74e2bb1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I saw this one, but all projects are the same so I thought maybe we leave it for another mass update, but maybe we can also just add it to the issue as something to do 👍
Interesting that your review also triggers a copilot session, even if you didn't assign copilot to the PR yourself. It is a bit annoying, maybe if we unassign copilot it stops doing that.
README.md
Outdated
| ## Quick Start | ||
|
|
||
| The `frequenz-dispatch` library provides a high-level interface to interact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is repeated, first appearing above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the redundant description sentence from the Quick Start section. Commit: 74e2bb1
| # Your dispatch logic here | ||
| print("Dispatcher ready!") | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also repeated.. though I am not sure if that is a problem or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(the main entry part)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the redundant "main entry point" reference from line 78. Commit: 0bcd222
Co-authored-by: Marenz <424752+Marenz@users.noreply.github.com>
Head branch was pushed to by a user without write access
README.md
Outdated
| running status of the dispatch changed in a way that could potentially | ||
| require the actor to start, stop or reconfigure itself. | ||
|
|
||
| ### Example using the running status change channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct, the example shows the managing of an actor which internally uses the running status channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the section title to "Example managing actors with dispatch events" which better describes what the example demonstrates. Commit: 0bcd222
Co-authored-by: Marenz <424752+Marenz@users.noreply.github.com>
|
I didn't pay much attention to the code itself as I thought it will mostly use the existing example. Interesting that it could mess it up. Maybe it didn't do as well as I thought after all. |
|
@Marenz do you want to give it a final look and force-merge if it looks good to you? |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR significantly enhances the README.md file to improve project discoverability and provide a better onboarding experience for new users. The changes restructure the documentation with clearer sections and practical examples to help users get started quickly.
- Added comprehensive installation instructions with both pip and pyproject.toml examples
- Introduced a Quick Start section with minimal code example for immediate user engagement
- Restructured content organization moving platform support before installation for better logical flow
|
Updated & corrected in #221 |
Improves the README based on the suggestions in #166: - Add expanded introduction describing the library purpose - Add Installation section with pip and pyproject.toml examples - Add Quick Start section with minimal working example - Move Supported Platforms section before Installation - Update documentation links to use /latest/ instead of /v0.1/ - Fix long lines using reference-style links - Update Ubuntu version to 24.04 - Update version references to v1.0.1 This is a corrected version of #176 targeting v1.x.x with updated API usage. Fixes #166 Supersedes #176
Enhanced the README.md file to improve the onboarding experience for new users and contributors as requested in the issue. The changes make the project more discoverable and easier to get started with.
Changes Made
✅ Added Quick Start Section
✅ Added Installation Section
python3 -m pip install frequenz-dispatchformat as requested✅ Improved Structure
✅ Fixed Line Length Compliance
Technical Validation
The changes are minimal and surgical, enhancing the onboarding experience without removing any existing valuable content.
Fixes #166.