docs: add DocBlocks for mdn-data and some <data-type>#134
Draft
buschtoens wants to merge 2 commits intofrenic:masterfrom
Draft
docs: add DocBlocks for mdn-data and some <data-type>#134buschtoens wants to merge 2 commits intofrenic:masterfrom
mdn-data and some <data-type>#134buschtoens wants to merge 2 commits intofrenic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #131.
This PR replicates the docs from
mdn-dataas DocBlocks and constrains the types a bit more based on the JSON schemas.It also adds
src/data/types.d.ts, which includes DocBlocks and template literal types for most data types. As template literal types are still quite limited, this is only a best-effort approach. The primary issues are:Actually making use of these template literal types is blocked by #124.
I've already had some of these types laying around from internal source code and thought the least I could to is upstream them here, so that they may get picked up.