Skip to content

Conversation

@febdao
Copy link

@febdao febdao commented Apr 17, 2025

Description

Fixed:

Desktop

  • Can homepage banner be the size of the viewport?
  • Banner height too large - can we make this height 600 (aside from the homepage, I would recommend lower level pages have a banner less than the VP height for scrolling purposes)- [-] Tiles currently inconsistent, body text in some tiles remains black on hover and appears to be a different font/size
  • Review tile grid - currently appears to be .75rem? (12px) - try 2rem
  • Same as above re. Row-gap, currently 24px (1.5rem), try 3.5rem
  • Can we reduce the width of the footer to max 600px/6 gridlines, looks like 7-8 at the moment?
  • Increase padding between socials to 12px and padding beneath ‘get in touch’ to 20px
  • Max width of H1 text in banner should be 10 gridlines, currently extends to full grid
  • Tiles are a little overwhelming with title, body copy and length, can rework this if you’d like all of that information in there (but would not recommend all of this information in there)

Mobile

  • Reduce line height of AOC to 39px
  • Increase padding between socials
  • Can mobile menu be the height of the viewport?
  • Increase line height of body text to 31px
  • Decrease intro text font size to 22px

Tablet

  • Increase padding between socials to 12px and padding below ‘get in touch’ to 20px
  • Decrease intro text font size to 22px
  • Increase line height of body text to 1.75rem

XL

  • Increase column-gap between tiles to 1.75rem and row-gap to 3rem
  • increase intro text size to 26px line height to 42px

@febdao febdao added the FE Frontend focussed label Apr 17, 2025
@febdao febdao requested a review from simesy April 17, 2025 01:15
@febdao febdao self-assigned this Apr 17, 2025
@febdao febdao marked this pull request as draft April 17, 2025 01:15
@febdao febdao marked this pull request as ready for review April 17, 2025 01:17
@febdao
Copy link
Author

febdao commented Apr 17, 2025

Hi @simesy
Do we need to fix these tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FE Frontend focussed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants