fix(tokenizer): Don't drop nominative reporter due to overlapping CitationTokens#284
Open
branliu0 wants to merge 2 commits intofreelawproject:mainfrom
Open
fix(tokenizer): Don't drop nominative reporter due to overlapping CitationTokens#284branliu0 wants to merge 2 commits intofreelawproject:mainfrom
branliu0 wants to merge 2 commits intofreelawproject:mainfrom
Conversation
Contributor
Author
|
This example makes it more clear that what's happening is that "Thompson, " is just being ignored when calculating full_span: |
Luis-manzur
requested changes
Oct 9, 2025
Contributor
Luis-manzur
left a comment
There was a problem hiding this comment.
Sorry for the delay, could you please resolve the conflicts and add a test case for when Thompson is the nominative reporter, thanks
Member
|
Please can you also add this example:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that eyecite was not parsing "Calderon v. Thompson, 523 U.S. 538" correctly because Thompson is also a nominative reporter.
(I used AI to help me with fixing this bug). The issue appears to be that when we have a token overlap, and we drop the token with the nominative reporter, the nominative reporter is no longer accounted for by any token.