WIP: Add dependencies as seen in oiio appveyor.yml #9
Conversation
|
@SidneyGuenther do you think we should add these too? I see he also builds qt5-base, which will make the build take a lot longer. |
I think we could try to add them but if they're adding more problems and build errors we should wait until somebody requests a feature of oiio which requires one of these dependencies.
This we should definitely just add if somebody requests it I guess. |
|
Okay, sounds good. I will wait with merging this just a bit, giving us a chance to debug Python 3.7 first. So, a blocker: #7 |
|
Okay, resuming this one. Although I think we should leave this unmerged until we have Linux builds too... so we can see what issues might come from these additions. |
fredrikaverpil
changed the title
|
The redundant dependencies already stated in the CONTROL files have been removed. I am now only adding whatever was specified in the official oiio repo's .appveyor.yml now. |
|
@SidneyGuenther sigh, seems like there is some issues when adding these extras on Ubuntu ...of course! |
|
Oops, my mistake! |
|
@SidneyGuenther What say you? I think so, unless you feel this somehow can be a burden maintainability wise. |
* Enable GitHub release * Add GitHub release notes * Improve GitHub release naming * Use better wheel names * Remove date from wheel * Only publish release for master branch * Use + as separator * Use + as separator * Use + as separator
Here are the deps used in the official repo's
appveyor.yml: https://github.com/OpenImageIO/oiio/blob/master/appveyor.yml#L52