Skip to content

Conversation

@hasnainpatil
Copy link

Description

Fixes #1956

The Problem:
Private Vimeo videos use a URL format like vimeo.com/12345/abcde (where abcde is the privacy hash). The previous regex only captured the numeric ID (12345) and ignored the hash. Consequently, the embed player URL was missing the required ?h=hash parameter, causing private videos to fail to load.

The Fix:

  • Updated the Vimeo regex in getEditorTools to capture the optional hash segment (Group 2).
  • Updated the ID extraction logic to append ?h={hash} to the video ID if a hash is detected.

Verification

Verified the regex logic against standard Vimeo URL formats:

  • Public URL: vimeo.com/123456 → Returns 123456
  • Private URL: vimeo.com/123456/abcde → Returns 123456?h=abcde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Private Vimeo videos don't load the video player

1 participant