fix(proxy): Preserve request body on redirect #343
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates nginx redirect status codes from 301 to 308 to preserve HTTP request methods and bodies during redirects. This ensures that POST requests with payloads are not converted to GET requests when redirecting.
- Changed host-based redirects from 301 to 308
- Changed HTTP-to-HTTPS redirects from 301 to 308
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| server_name _; | ||
|
|
||
| location ^~ /.well-known/acme-challenge/ { | ||
| return 301 http://ssl.{{ domain }}$request_uri; |
There was a problem hiding this comment.
For consistency with the PR's goal of preserving request bodies on redirects, this ACME challenge redirect should also be changed from 301 to 308. While ACME challenges typically use GET requests, using 308 maintains consistency with the other permanent redirects in this configuration and follows the same principle of preserving request methods.
| return 301 http://ssl.{{ domain }}$request_uri; | |
| return 308 http://ssl.{{ domain }}$request_uri; |
|
#305 - thanks :) |
fixes #305
When users make requests to http endpoint instead of https (webhooks), the request body gets dropped. Using 308 prevents that.