Parser#initialize: read file when filename given#3
Open
lindes wants to merge 1 commit intofrancois:masterfrom
Open
Parser#initialize: read file when filename given#3lindes wants to merge 1 commit intofrancois:masterfrom
lindes wants to merge 1 commit intofrancois:masterfrom
Conversation
It seems natural to pass a filename to initialize, so if whatever we're given is a file that exists, read its contents instead of using it as string data directly. (It occurs to me that we may want to duplicate the string otherwise, but I'm unsure what other use cases might be present that I'm not thinking of, so I'm leaving that out for now.) Fixes francois#2 Note: Chosing to bump version to 0.2.2 because rubygems has a 0.2.1 from somewhere that I couldn't find. This change technically Copyright 2021 by David Lindes, and I agree to license it under the same terms as the rest of this repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems natural to pass a filename to initialize, so if whatever we're
given is a file that exists, read its contents instead of using it as
string data directly.
(It occurs to me that we may want to duplicate the string otherwise, but
I'm unsure what other use cases might be present that I'm not thinking
of, so I'm leaving that out for now.)
Fixes #2
Note: Chosing to bump version to 0.2.2 because rubygems has a 0.2.1 from
somewhere that I couldn't find.
This change technically Copyright 2021 by David Lindes, and I agree to
license it under the same terms as the rest of this repository.