Skip to content

Fix php8.4 deprecations #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klimick merged 4 commits into from
Mar 9, 2025
Merged

Fix php8.4 deprecations #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d11ccef
Fix php8.4 deprecations
innot-cop Mar 9, 2025
dd86795
Bump action/cache to v3 version
innot-cop Mar 9, 2025
eaf1702
Fix psalm
innot-cop Mar 9, 2025
e00bd38
Merge branch 'fp4php:master' into master
InnoT20 Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v2

- name: Install dependencies
run: composer install --prefer-dist --no-progress
- name: Install dependencies
run: composer install --prefer-dist --no-progress

- name: Cache Composer dependencies
id: composer-cache
uses: actions/cache@v2
with:
path: vendor
key: ${{ runner.os }}-php-${{ github.sha }}
- name: Cache Composer dependencies
id: composer-cache
uses: actions/cache@v3
with:
path: vendor
key: ${{ runner.os }}-php-${{ github.sha }}

psalm:
runs-on: ubuntu-latest
Expand All @@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v2
- name: Restore cached composer dependencies
id: composer-cache
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: vendor
key: ${{ runner.os }}-php-${{ github.sha }}
Expand All @@ -52,18 +52,18 @@ jobs:

- name: Restore cached composer dependencies
id: composer-cache
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: vendor
key: ${{ runner.os }}-php-${{ github.sha }}

- name: Run test suite
run: php vendor/bin/phpunit

# - name: Check PhpUnit coverage percentage
# run: php vendor/bin/coverage-check build/logs/clover.xml 85
# - name: Check PhpUnit coverage percentage
# run: php vendor/bin/coverage-check build/logs/clover.xml 85

- name: Upload coverage results to Coveralls
env:
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: php vendor/bin/php-coveralls --coverage_clover=build/logs/clover.xml -v
run: php vendor/bin/php-coveralls --coverage_clover=build/logs/clover.xml -v
16 changes: 8 additions & 8 deletions src/Fp/Functions/Callable/Compose.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@
function compose(
callable $aToB,
callable $bToC,
callable $cToD = null,
callable $dToF = null,
callable $fToG = null,
callable $gToH = null,
callable $hToI = null,
callable $iToJ = null,
callable $jToK = null,
callable $kToL = null,
?callable $cToD = null,
?callable $dToF = null,
?callable $fToG = null,
?callable $gToH = null,
?callable $hToI = null,
?callable $iToJ = null,
?callable $jToK = null,
?callable $kToL = null,
): callable
{
$callableChain = filterNotNull([$aToB, $bToC, $cToD, $dToF, $fToG, $gToH, $hToI, $iToJ, $jToK, $kToL]);
Expand Down