Skip to content

disable CRL checks when OCSP responder URL is available #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grk-it wants to merge 1 commit into
base: v3.2.3_foxpass
Choose a base branch
from
Open

disable CRL checks when OCSP responder URL is available #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2708,6 +2708,12 @@ static ocsp_status_t ocsp_check(REQUEST *request, X509_STORE *store, X509 *issue

RDEBUG2("ocsp: Using responder URL \"http://%s:%s%s\"", host, port, path);

/* The underlying openssl library function: OCSP_response_get1_basic failure due to CRL checks fails the OCSP operation even though CRL checks are not needed in this flow. Disable CRL checks in this flow. */
/* ref: https://docs.openssl.org/3.4/man3/X509_STORE_get0_param/#synopsis */
X509_VERIFY_PARAM *param = X509_STORE_get0_param(store);
if (param != NULL) {
X509_VERIFY_PARAM_clear_flags(param, X509_V_FLAG_CRL_CHECK | X509_V_FLAG_CRL_CHECK_ALL);
}
/* Check host and port length are sane, then create Host: HTTP header */
if ((strlen(host) + strlen(port) + 2) > sizeof(hostheader)) {
RWDEBUG("(TLS) ocsp: Host and port too long");
Expand Down
Loading