fix(anvil): variable shadowing bug in ReadyTransactions::remove_with_markers#13436
Merged
mattsse merged 2 commits intofoundry-rs:masterfrom Feb 14, 2026
Merged
fix(anvil): variable shadowing bug in ReadyTransactions::remove_with_markers#13436mattsse merged 2 commits intofoundry-rs:masterfrom
mattsse merged 2 commits intofoundry-rs:masterfrom
Conversation
letmehateu
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Feb 14, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
Correct fix for a real variable shadowing bug in remove_with_markers. The old code shadowed hash (the tx being removed) with the provider's hash from provided_markers.get(mark), then searched unlocks for the wrong value — meaning unlock-list entries were never actually cleaned up. The rename to provider_hash/provider_tx and the comparison against the outer hash is the right fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes variable shadowing bug that caused incorrect transaction removal from unlock lists.