Skip to content

fix(config): normalize deny_warnings from env vars#13434

Merged
onbjerg merged 1 commit intofoundry-rs:masterfrom
aso20455:fix/config-deny-warnings-env
Feb 13, 2026
Merged

fix(config): normalize deny_warnings from env vars#13434
onbjerg merged 1 commit intofoundry-rs:masterfrom
aso20455:fix/config-deny-warnings-env

Conversation

@aso20455
Copy link
Contributor

normalize_defaults uses self.deny_warnings to check if the deprecated deny_warnings flag was set, but self here is always Config::default() (where deny_warnings = false), so the condition is dead code.

The TOML path works fine because BackwardsCompatTomlProvider converts the deny_warnings key to deny in the dict directly. But env vars like FOUNDRY_DENY_WARNINGS=true bypass that provider and rely on normalize_defaults to do the conversion — which never triggers.

The fix reads deny_warnings from the figment, same pattern already used for solc/evm_version a few lines above in the same function.

Introduced in c7d9703 (#11445).

@onbjerg onbjerg merged commit 6612bd6 into foundry-rs:master Feb 13, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants