fix(config): normalize deny_warnings from env vars#13434
Merged
onbjerg merged 1 commit intofoundry-rs:masterfrom Feb 13, 2026
Merged
fix(config): normalize deny_warnings from env vars#13434onbjerg merged 1 commit intofoundry-rs:masterfrom
onbjerg merged 1 commit intofoundry-rs:masterfrom
Conversation
onbjerg
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalize_defaultsusesself.deny_warningsto check if the deprecateddeny_warningsflag was set, butselfhere is alwaysConfig::default()(wheredeny_warnings = false), so the condition is dead code.The TOML path works fine because
BackwardsCompatTomlProviderconverts thedeny_warningskey todenyin the dict directly. But env vars likeFOUNDRY_DENY_WARNINGS=truebypass that provider and rely onnormalize_defaultsto do the conversion — which never triggers.The fix reads
deny_warningsfrom the figment, same pattern already used forsolc/evm_versiona few lines above in the same function.Introduced in c7d9703 (#11445).