fix(cli): add Etherlink Shadownet to has_different_gas_calc#13430
Open
fix(cli): add Etherlink Shadownet to has_different_gas_calc#13430
Conversation
Add chain ID 127823 (Etherlink Shadownet Testnet) to the has_different_gas_calc function so forge script --broadcast re-estimates gas via eth_estimateGas on this chain. The NamedChain variant does not exist in alloy-chains yet, so we match the raw chain ID directly. Closes #13425
gakonst
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Etherlink Shadownet (chain ID 127823) to
has_different_gas_calcsoforge script --broadcastre-estimates gas viaeth_estimateGason this chain.Motivation
Etherlink uses a non-standard gas model with inclusion fees (~600k gas on top of EVM execution gas). Without RPC-based gas estimation,
forge scriptsends transactions with gas limits based on local EVM simulation only, which the sequencer rejects.Etherlink Mainnet (42793) and Ghostnet Testnet (128123) are already handled via
NamedChain, but Shadownet (127823) is not yet in alloy-chains, so we match the raw chain ID.Closes #13425
Changes
crates/cli/src/utils/cmd.rs: add chain ID 127823 check before theNamedChainmatch