Skip to content

docs: fix IERC4626 previewWithdraw comment #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onbjerg merged 3 commits into from
Feb 6, 2026
Merged

docs: fix IERC4626 previewWithdraw comment #811

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93eda8d
docs: fix IERC4626 previewWithdraw comment
NftCryptoHunter007 Feb 4, 2026
dfb8fdf
Merge branch 'master' into fix-ierc4626-withdraw-doc
zerosnacks Feb 5, 2026
86d830b
Merge branch 'master' into fix-ierc4626-withdraw-doc
zerosnacks Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/interfaces/IERC4626.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ interface IERC4626 is IERC20 {
/// - MUST NOT revert.
///
/// NOTE: any unfavorable discrepancy between convertToShares and previewWithdraw SHOULD be considered slippage in
/// share price or some other type of condition, meaning the depositor will lose assets by depositing.
/// share price or some other type of condition, meaning the depositor will lose assets by withdrawing.
function previewWithdraw(uint256 assets) external view returns (uint256 shares);

/// @notice Burns shares from owner and sends exactly assets of underlying tokens to receiver.
Expand Down