Skip to content

Attributes for inner link in button and menu-item #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AliakseiT wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Attributes for inner link in button and menu-item #94

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37127f1
Initial implementation with explicit href-clicktracking attribute
Nov 30, 2017
480b440
generalized support for inner link attributes, all href- attributes a…
Nov 30, 2017
c24f611
Merge branch 'develop'
DanielRuf Aug 2, 2020
ba5db21
Merge branch 'master' into href-attributes-support
DanielRuf Aug 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/componentFactory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,12 @@ module.exports = function(element) {

// If we have the href attribute we can create an anchor for the inner of the button;
if (element.attr('href')) {
inner = format('<a %s href="%s"%s>%s</a>', attrs, element.attr('href'), target, inner);
// support for all types of href- attributes for inner link (e.g. Sendgrid's clicktracking="off")
var hrefAttrs = attrs.split(' ')
.filter(attr => attr.startsWith('href-'))
.map(attr => ' '+attr.replace('href-',''))
.join();
inner = format('<a %s href="%s"%s>%s</a>', hrefAttrs, element.attr('href'), target, inner);
}

// If the button is expanded, it needs a <center> tag around the content
Expand Down Expand Up @@ -102,7 +107,12 @@ module.exports = function(element) {
if (element.attr('class')) {
classes = classes.concat(element.attr('class').split(' '));
}
return format('<th %s class="%s"><a href="%s"%s>%s</a></th>', attrs, classes.join(' '), element.attr('href'), target, inner);
// support for all types of href- attributes for inner link (e.g. Sendgrid's clicktracking="off")
var hrefAttrs = attrs.split(' ')
.filter(attr => attr.startsWith('href-'))
.map(attr => ' '+attr.replace('href-',''))
.join();
return format('<th %s class="%s"><a %s href="%s"%s>%s</a></th>', attrs, classes.join(' '), hrefAttrs, element.attr('href'), target, inner);

// <center>
case this.components.center:
Expand Down