Skip to content

Fix small holes in inflate #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fontanf merged 1 commit into from
Jan 19, 2026
Merged

Fix small holes in inflate #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/offset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,22 @@ ShapeWithHoles shape::inflate(
// file << std::setw(4) << json << std::endl;
//}

// Remove small holes.
ShapeWithHoles shape_tmp;
shape_tmp.shape = shape.shape;
for (ShapePos hole_pos = 0;
hole_pos < (ShapePos)shape.holes.size();
++hole_pos) {
const Shape& hole = shape.holes[hole_pos];
auto wh = hole.compute_width_and_height();
if (!strictly_greater(wh.first, 2 * offset)
|| !strictly_greater(wh.second, 2 * offset)) {
continue;
}
shape_tmp.holes.push_back(hole);
}
shape = shape_tmp;

std::vector<ShapeWithHoles> union_input = {{shape}};

// Inflate outline.
Expand Down Expand Up @@ -213,7 +229,6 @@ ShapeWithHoles shape::inflate(
++hole_pos) {
const Shape& hole = shape.holes[hole_pos];

auto wh = hole.compute_width_and_height();
if (hole.is_circle()) {
Shape circle = hole;
ShapeElement& element = circle.elements[0];
Expand All @@ -224,9 +239,6 @@ ShapeWithHoles shape::inflate(
element.end = element.start;
union_input.push_back({circle});
}
} else if (!strictly_greater(2 * wh.first, offset)
&& !strictly_greater(2 * wh.second, offset)) {
// Hole is removed.
} else {
ElementPos element_prev_pos = hole.elements.size() - 1;
const ShapeElement& element_prev = hole.elements[element_prev_pos];
Expand Down
Loading