STSMACOM-468: Enabled <ColumnManager> in the results list#1339
Open
rasmuswoelk wants to merge 10 commits intomasterfrom
Open
STSMACOM-468: Enabled <ColumnManager> in the results list#1339rasmuswoelk wants to merge 10 commits intomasterfrom
rasmuswoelk wants to merge 10 commits intomasterfrom
Conversation
…rt> and removed the previous implementation.
zburke
requested changes
Mar 10, 2021
Member
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
The search results pane does not properly display results for me on this branch. I suspect this is actually a problem with the SSC PR rather than anything here in ui-inventory, but I don't think we can merge this until that's resolved.
Note in the screenshot that result-rows are present in the DOM (it's clipped, but the results-pane title shows "268 records found") but the <a> elements have no text content and the DOM-inspector shows 0 height.
|
Kudos, SonarCloud Quality Gate passed! |
|
Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-inventory/job/PR-1339/13/ |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.folio.org/browse/STSMACOM-468
Purpose
This is a follow-up PR for the work done in STSMACOM-468.
We recently added the
<ColumnManager>component which can be used for toggling and persisting the visibility of columns in a<MultiColumnList>. This component is built into the<SearchAndSort>and can be activated and utilized with very little effort.While working on STSMACOM-468 I tested the implementation in various modules including ui-inventory.
Test the changes here:
https://folio-styling.testing.samhaeng.com/inventory
Approach
I enabled the
<ColumnManager>via.<SearchAndSort>, removed the existing logic/UI since it's now redundant and updated the related tests.Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.