Skip to content

Comments

fix: prevent updating color if the new value equals the previous value#85

Open
GregoMac1 wants to merge 2 commits intomainfrom
68-fix-hsl-input-bug
Open

fix: prevent updating color if the new value equals the previous value#85
GregoMac1 wants to merge 2 commits intomainfrom
68-fix-hsl-input-bug

Conversation

@GregoMac1
Copy link
Collaborator

No description provided.

@GregoMac1 GregoMac1 requested a review from fmaclen January 9, 2025 00:28
@GregoMac1 GregoMac1 self-assigned this Jan 9, 2025
Copy link
Owner

@fmaclen fmaclen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a short test for this behavior?

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2025

Deploying chromabox with  Cloudflare Pages  Cloudflare Pages

Latest commit: 182917c
Status: ✅  Deploy successful!
Preview URL: https://0b36d7b0.chromabox-7t1.pages.dev
Branch Preview URL: https://68-fix-hsl-input-bug.chromabox-7t1.pages.dev

View logs

@GregoMac1 GregoMac1 requested a review from fmaclen January 10, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HSL: when focusing and then "blur" the field sometimes changes the other colors

2 participants