Add option to group locally imported packages #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleich
requested changes
May 26, 2021
Member
gleich
left a comment
gleich
left a comment
There was a problem hiding this comment.
Hey @julianscheel! Thanks for this PR, this would be great to have. Please add some tests and update to the latest main.dart? Besides that everything looks good to me!
Packages which are not pulled from a remote, but read from a local path can be grouped individually with this option. Signed-off-by: Julian Scheel <julian@jusst.de>
Signed-off-by: Julian Scheel <julian@jusst.de>
julianscheel
force-pushed
the
feature/local-packages
branch
from
40eddb4 to
db46bf9
Compare
Author
|
Hi @gleich, sorry this took so long. I finally got back to this, rebased to current master and implemented some tests. |
Member
|
Thank you so much for this @julianscheel! I'll make sure to review it sometime this weekend. Thanks again! |
Author
|
ping @gleich |
Member
|
Hello @julianscheel. Thank you so much for sending in this PR but I am sadly archiving import_sorter (see #63). This means that your work will not be merged into import_sorter. Thank you so much for the effort in trying to improve the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages which are not pulled from a remote, but read from a local path
can be grouped individually with this option.