Fix zoomAndPan not having an effect#920
Conversation
Hide controls while interacting with zoomAndPan.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #920 +/- ##
==========================================
- Coverage 44.91% 44.47% -0.44%
==========================================
Files 21 21
Lines 1574 1585 +11
==========================================
- Hits 707 705 -2
- Misses 867 880 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Any news from the team regarding this PR ? @abalmagd : Maybe you could add the |
|
@maxbritto The I added it to the tree if Also, I think zooming or panning via the controller does not require ui to be updated as it wasn't done with gestures, so the |
|
Nice change, hopefully this will help reviewers accept it 🤞 |
|
@abalmagd please re-sync your changes with Thanks |
|
Also, revert the formatting. Thanks. |
re-sync with master revert formatted line for LayoutBuilder
|
@diegotori Done, although most of the formatted/white space is due to inserting/replacing some parent widgets |
|
@abalmagd please re-sync your changes again with Once that's done, then you should be able to keep the format. Otherwise, run |
# Conflicts: # lib/src/player_with_controls.dart
|
@diegotori Re-synced with master |
|
@abalmagd published in version |
* commit 'c094ed8ec7751e597a0f09dcf5b6689503793d04': chewie, version 1.12.1. Addresses Issue fluttercommunity#920. Upgraded iOS example project. Ran dart format on library. Added improvements to the Github workflow. refactor(player-with-controls): replace provider call to context.read refactor(player-with-controls): Remove interactive viewer from tree if its not used Fix zoomAndPan not having an effect. Hide controls while interacting with zoomAndPan. # Conflicts: # lib/src/player_with_controls.dart
Tests were made with version
1.11.3example appCloses zoomAndPan functionality #678
InteractiveViewerto the parentStack.zoomAndPan: trueto example app controller.