Skip to content

upload nightly to deken, manual upload setting for release#118

Merged
jamesb93 merged 1 commit intoflucoma:mainfrom
ben-wes:deken-upload
Feb 5, 2026
Merged

upload nightly to deken, manual upload setting for release#118
jamesb93 merged 1 commit intoflucoma:mainfrom
ben-wes:deken-upload

Conversation

@ben-wes
Copy link
Contributor

@ben-wes ben-wes commented Jan 3, 2026

this removes the deken upload logic for release runs and just expects the checkbox in the manually dispatched run (seems more elegant and logical anyway):

github release run dialog

besides that (and more importantly), nightly builds are also uploaded to deken - as suggested in #111 (comment). the version is derived the same way as for releases, but an additional -nightly suffix is added. the result looks like this (these were my test runs and i removed the packages again):

deken with flucoma result

this works pretty well; the only issue that i see is that users will probably install the nightly version by default - the deken app has preference toggles to only display the latest version and only for the system architecture. with these set, the result looks like this (but it's obviously exactly the same for Gem snapshots):

deken with flucoma result - only nightly

to properly run, this requires flucoma/actions#8 and a v6 tag on the actions side.

@umlaeute
Copy link

umlaeute commented Feb 3, 2026

just a sidenote (and I didn't see this PR, so I started #119 which is in the same vein):

as the admin of the deken server, i see that people are searching for flucoma.
i'm afraid that the amount of people who search for "fluidcorpusmanipulation" is rather small (obviously @ben-wes did a search; there were two more in the last 2 month as well)

@ben-wes
Copy link
Contributor Author

ben-wes commented Feb 3, 2026

obviously @ben-wes did a search

there should be quite a few of my "fluidcorpusmanipulation" (or truncated with wildcard) searches in the logs from the times i tested the deken upload. :)

i agree with #119 by the way. when first installing it, i was confused about the directory name since i also expected flucoma - in line with how i heard people refer to it. also, lowercase seemed more consistent with most other libraries - except for Gem. ;)

so for "SEO" reasons (and based on your deken insights), naming it flucoma certainly seems better. i actually had it that way at some point when working on #111, but then changed it again to avoid breaking changes for patches with [declare -path FluidCorpusManipulation -lib fluid_libmanipulation] (and for users with Pd's path preferences set accordingly).

i don't have a strong opinion right now - but i'll gladly adapt this PR if needed.

EDIT: if there's a decision to add breaking changes, the name of the library binary might also be questioned (i would have expected flucoma there as well). but i added a README.deken.pd with #111 that explains this stuff and also provides a (hacky) way of simply adding the library path via a add-to-path message.

@umlaeute
Copy link

umlaeute commented Feb 4, 2026

i don't have a strong opinion right now

me neither :-)

my entire interaction with this team was merely triggered by a recent glance at the deken log files to look for patterns in searches that don't return any results (in the very late wake of this thread), and flucoma showed up a couple of times (I didn't notice fluidcorpusmanipulation until i actively search for it)

@jamesb93
Copy link
Member

jamesb93 commented Feb 5, 2026

i don't have a strong opinion right now

me neither :-)

my entire interaction with this team was merely triggered by a recent glance at the deken log files to look for patterns in searches that don't return any results (in the very late wake of this thread), and flucoma showed up a couple of times (I didn't notice fluidcorpusmanipulation until i actively search for it)

I would be overreaching to ask, but I will anyway: it might also make sense to consider implementing fuzzy search on the server side. Flucoma and FluidCorpusManipulation could then get people where they need to go relatively equally. I've had good success with: https://github.com/leeoniya/uFuzzy

@jamesb93 jamesb93 merged commit fca2a18 into flucoma:main Feb 5, 2026
@umlaeute
Copy link

umlaeute commented Feb 5, 2026

it might also make sense to consider implementing fuzzy search on the server side.

we already have a feature request https://git.iem.at/zmoelnig/deken-server/-/issues/28 that goes into that direction.

however, my idea of "fuzzy search" was always about guessing the users' intent rather than fixing the maintainer's intent.

Flucoma and FluidCorpusManipulation could then get people [...]

ah well.
we already have libraries like the "Graphics Environment for Multimedia", which people happily find when searching for it's acronym "gem".
it seems that this is a good role model ;-)

I would be overreaching to ask

personally I think it is overkill.

but then: PRs are welcome https://git.iem.at/zmoelnig/deken-server/

@tremblap
Copy link
Member

tremblap commented Feb 5, 2026

ok we've merged and it doesn't upload... I'll try to see why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants