Add support for shift+enter to insert line breaks on mac #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome and windows does this by default but mac/safari does ctrl+enter. This update allows people in safari to also use shift+enter so that the behaviour is consistent.
|
I was looking into this because of this new support ticket: https://app.bananastand.org/organizations/52/teams/1/tasks/5677662 That change to wysihtml5 does not seem to work properly for me in Chrome - often the cursor jumps down without changing the text, and if the cursor is sitting at the end of a bolded string it doesn't work at all (just acts as if enter was hit). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome and windows does this by default but mac/safari does ctrl+enter.
This update allows people in safari to also use shift+enter so that the behaviour is consistent.
I really wanted to write tests for this and I spent some time installing the dependcies to get selenium working but I got stuck with firefox booting and immediately crashing whenever I ran
npm test...any thoughts?