working on #68 for the _linear_model file. In the process I discovere… #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d an oddity that has spawned #92
Collaborator
Author
|
In the process of trying to rewrite unit tests to address #90, I found it difficult to call |
pavelkomarov
commented
Jun 6, 2025
| # polyfit | ||
| r = np.polyfit(t, x, order, w=w)[::-1] | ||
| r = np.polyfit(t, x, polynomial_order, w=weights) # polyfit returns highest order first | ||
| dr = np.polyder(r) # power rule already implemented for us |
Collaborator
Author
There was a problem hiding this comment.
Numpy truly is a deep well of useful functions.
Merged
pavelkomarov
commented
Jun 7, 2025
| :param epsilon: | ||
| :param rows_of_interest: | ||
| :return: | ||
| """Given state and the derivative, find the system evolution and measurement matrices. |
Collaborator
Author
There was a problem hiding this comment.
I hope this description isn't wildly wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d an oddity that has spawned #92