Skip to content

Conversation

@pavelkomarov
Copy link
Collaborator

…table/intro/add-project.html#manually-import-your-docs

@florisvb
Copy link
Owner

florisvb commented Jun 5, 2025

Is it okay that this is failing checks?

@pavelkomarov
Copy link
Collaborator Author

Thanks for merging #84. I'm pulling those changes in to this PR, which will kick off the build again.

@pavelkomarov
Copy link
Collaborator Author

pavelkomarov commented Jun 6, 2025

It passes! 🎉 We should still figure out what we're doing about #73. Yuying (@luckystarufo) has the docs pointed at his own fork, which was probably just for convenience because he had admin powers on that and could give readthedocs full access. I did hear from him, but he said he's out of the country until this weekend. Best case scenario is the readthedocs points at your (this) copy, @florisvb, which means maybe you give Yuying or me admin access on this version, or Yuying vacates the pynumdiff project name, and you take over management of readthedocs, since he's no longer actively involved in the project. We're supposed to need a .readthedocs.yml "configuration file" according to https://docs.readthedocs.com/platform/stable/intro/add-project.html. Hence this PR.

We'll have to watch whether readthedocs triggers builds appropriately and succeeds. We may need to further modify the contents of .readthedocs.yml. Configuration files can be kind of finicky to set up, but I'm finding generative AI is pretty good at ingesting all the instructions around the internet and making me mostly working .yml.

@florisvb florisvb merged commit b171ac5 into master Jun 6, 2025
1 check passed
@florisvb
Copy link
Owner

florisvb commented Jun 6, 2025 via email

@pavelkomarov pavelkomarov deleted the readthedocs-yaml-inclusion branch June 7, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants