Skip to content

EDM-3097: Disabled import option has a tooltip #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
celdrake merged 1 commit into from
Feb 5, 2026
Merged

EDM-3097: Disabled import option has a tooltip #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/i18n/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,7 @@
"URL": "URL",
"Sync status": "Sync status",
"Last transition": "Last transition",
"No Git repositories found": "No Git repositories found",
"Use an existing Git repository": "Use an existing Git repository",
"Use a new Git repository": "Use a new Git repository",
"A resource sync is an automated Gitops method that helps manage your imported fleets by monitoring source repository changes and updating your fleet configuration accordingly.": "A resource sync is an automated Gitops method that helps manage your imported fleets by monitoring source repository changes and updating your fleet configuration accordingly.",
Expand Down
19 changes: 11 additions & 8 deletions libs/ui-components/src/components/Fleet/ImportFleetWizard/steps/RepositoryStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import FormSelect from '../../../form/FormSelect';
import FlightCtlForm from '../../../form/FlightCtlForm';
import { usePermissionsContext } from '../../../common/PermissionsContext';
import { RESOURCE, VERB } from '../../../../types/rbac';
import WithTooltip from '../../../common/WithTooltip';

export const repositoryStepId = 'repository';

Expand Down Expand Up @@ -93,14 +94,16 @@ const RepositoryStep = ({ repositories, hasLoaded }: { repositories: Repository[
{canCreateRepo && (
<FormSection>
<FormGroup isInline>
<Radio
isChecked={values.useExistingRepo}
onChange={() => setFieldValue('useExistingRepo', true, true)}
id="existing-repo"
name="repo"
label={t('Use an existing Git repository')}
isDisabled={noRepositoriesExist}
/>
<WithTooltip showTooltip={noRepositoriesExist} content={t('No Git repositories found')}>
<Radio
isChecked={values.useExistingRepo}
onChange={() => setFieldValue('useExistingRepo', true, true)}
id="existing-repo"
name="repo"
label={t('Use an existing Git repository')}
isDisabled={noRepositoriesExist}
/>
</WithTooltip>
<Radio
isChecked={!values.useExistingRepo}
onChange={() => setFieldValue('useExistingRepo', false, true)}
Expand Down
6 changes: 5 additions & 1 deletion libs/ui-components/src/components/Repository/CreateRepository/CreateRepositoryForm.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,9 @@
}

.fctl-create-repo__adv-section--nested {
margin-left: 1.5rem;
margin-left: 1.5rem;
}

.fctl-create-repo__rs-checkbox {
--pf-v6-c-check__input--TranslateY: 0.75rem;
}
1 change: 1 addition & 0 deletions libs/ui-components/src/components/Repository/CreateRepository/CreateRepositoryForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ const CreateRepositoryFormContent = ({ isEdit, isReadOnly, onClose, children }:
{showResourceSyncs && canCreateRS && (
<Checkbox
id="use-resource-syncs"
className="fctl-create-repo__rs-checkbox"
Copy link
Collaborator Author

@celdrake celdrake Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkbox was misaligned with the label.
Using CheckboxField or other solutions didn't work.

label={
<LabelWithHelperText
label={t('Use resource syncs')}
Expand Down