Skip to content

EDM-3215: Decommissioned devices cannot be modified #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
celdrake wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EDM-3215: Decommissioned devices cannot be modified #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions libs/ui-components/src/components/Device/DeviceDetails/DeviceDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ const DeviceDetailsPage = ({ children, hideTerminal }: DeviceDetailsPageProps) =
const isEnrolled = !device || isDeviceEnrolled(device);

const { checkPermissions } = usePermissionsContext();
const [hasTerminalAccess, canDelete, canEdit, canDecommission, canResume] =
const [hasTerminalAccess, canDelete, hasEditPermissions, canDecommission, canResume] =
checkPermissions(deviceDetailsPermissions);

const canEdit = hasEditPermissions && isEnrolled;
const canOpenTerminal = hasTerminalAccess && isEnrolled;

const { deleteAction, deleteModal } = useDeleteAction({
Expand Down Expand Up @@ -159,7 +160,7 @@ const DeviceDetailsPage = ({ children, hideTerminal }: DeviceDetailsPageProps) =
isEnrolled ? (
<DetailsPageActions>
<DropdownList>
{canEdit && (
{hasEditPermissions && (
<DropdownItem
onClick={() => navigate({ route: ROUTE.DEVICE_EDIT, postfix: deviceId })}
{...editActionProps}
Expand All @@ -186,15 +187,20 @@ const DeviceDetailsPage = ({ children, hideTerminal }: DeviceDetailsPageProps) =
<Route
path="details"
element={
<DeviceDetailsTab device={device} refetch={refetch} canEdit={canEdit}>
<DeviceDetailsTab device={device} refetch={refetch} canEdit={hasEditPermissions}>
{children}
</DeviceDetailsTab>
}
/>
<Route
path="yaml"
element={
<YamlEditor apiObj={device} refetch={refetch} disabledEditReason={editDisabledReason} canEdit={canEdit} />
<YamlEditor
apiObj={device}
refetch={refetch}
disabledEditReason={editDisabledReason}
canEdit={hasEditPermissions}
/>
}
/>
{!hideTerminal && canOpenTerminal && <Route path="terminal" element={<TerminalTab device={device} />} />}
Expand Down