Open
Conversation
WalkthroughUpdated lodash dependency from version 4.17.21 to 4.17.23 and added lodash-es dependency with version 4.17.23 to package.json. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Line 53: Remove the redundant direct dependency "lodash-es" from package.json
(it is provided transitively by formik and your code imports CommonJS "lodash"
not "lodash-es"); delete the "lodash-es" entry, update the lockfile by running
the package manager install (npm install / yarn install / pnpm install) and
rebuild, and verify no imports/reference in codebase rely on "lodash-es"
(confirm package name usage in imports and adjust to "lodash" if needed) to
avoid duplicate mismatched versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/flightctl/flightctl-ui/security/dependabot/67 and https://github.com/flightctl/flightctl-ui/security/dependabot/68
npm list lodash/lodash-esshows all packages use 4.17.23Summary by CodeRabbit